search

backstopmedia / bleeding-edge-sample-app

A sample app for a Bleeding Edge Press book.
Apache License 2.0
680 stars 297 forks source link

React router #20

Closed karlmikko closed 10 years ago

karlmikko commented 10 years ago

Now with server side rendering with async state - the state used for the render is also passed to the client for initial render on the client for super fast perf.

This show how to get initial async state data from the route handler. I haven't quite worked out how to perform test on this though. Will need some help on that.

karlmikko commented 10 years ago

I have this now passing tests and ready to roll! There will be some more work in the future on the server side a my upstream changes get committed, there may also be some more modification to the upstream to get the tick of approval from the react-router crew.

Please merge this pull and start working with it. I am happy with it, but would like someone else to look over it before the PR is landed.

You will see that the tests for the main_nav have changed as the tests for what route is active is covered in react-router, as I changed to use the component.

jonathan-beebe commented 10 years ago

@karlmikko I'll have a chance to look at it tonight. Thanks for taking this on!

jonathan-beebe commented 10 years ago

Your work on the router looks great. Admittedly I'm fairly inexperienced with React on the server-side, but I think this gives us a great foundation to work from.