backstopmedia / nest-book-example

69 stars 34 forks source link

Add some basic modules #5

Closed adrien2p closed 6 years ago

adrien2p commented 6 years ago

Contains :

I propose the following things :

adrien2p commented 6 years ago

I just need to add some tests and add an .env file if that is ok for you. I am waiting for your feedback before continuing ;)

yharaskrik commented 6 years ago

+1 for the sequelize and passport

adrien2p commented 6 years ago

I think that we should create a slack room to discuss about what we are doing and avoid duplicating work.

We can also work in concert on certain branch if it necessary to share capabilities.

What do you think about that ?

Because it will be much easier to exchange between us than using email or anything else.

yharaskrik commented 6 years ago

Was thinking that would be a good idea. Easier to communicate that way.

davguij commented 6 years ago

+1 to Slack. I'll create us a group right away.

FWIW, I also created a basic skeleton at https://github.com/backstopmedia/nest-book-example/pull/3, without really any code in it, just so that we could then divide the work among us.

Maybe you @adrien2p could go through it and incorporate the stuff you find useful from there (if any)?

Also, since we are going to cover several types of DBs/ORMs, I'm thinking it might be good to either a) maintain several branches, on for each ORM or b) create several modules that can then be added/removed from the AppModule.

What do you guys think?

yharaskrik commented 6 years ago

My vote would be for one per branch, but that is just me, keep it separated and clean.

davguij commented 6 years ago

(sidenote) I just invited you guys to the Slack channel.