search

backstopmedia / tensorflowbook

457 stars 296 forks source link

migrate tensorflow 1.0 or higher #23

Open BGPark opened 7 years ago

BGPark commented 7 years ago

Migrate some examples to the new API (1.0 or later). I have confirmed that my modifications work with TF versions 1.0 and 1.1. However, the remaining uncommitted examples (araxiv and CNNs examples) still have problems with the new API.

It is not perfect, but I hope it helps others.

johndpope commented 7 years ago

@backstopmedia / @samjabrahams - please update this - or specify hard version with pip install requirements to older tensorflow.

michael-GitHub-0 commented 7 years ago

Thanks, BGPark. I was able to adjust much of the code to suit the new API but your code is making my life much easier. Hopefully, the authors will update their code.

danijar commented 7 years ago

@michael-GitHub-0 Did all examples work for you with this patch?

michael-GitHub-0 commented 7 years ago

@danijar I am sorry, I haven't tried all of the code by BGPark. I only found this while working on chapter 5, and then I only pop over if I get stuck. I am new to GitHub.

penchy-zju commented 7 years ago

It would be really nice if all examples are fixed under tf 1.0 or higher.

michael-GitHub-0 commented 7 years ago

The book started out very well, but something changed beginning with chapter 5. The writing was less explanatory (more typos, too) and more difficult to work with. I have made a few GitHub posts and sometimes the authors respond, and sometimes they don't. I have moved on to another book, myself.

CosmosNing commented 7 years ago

Thank you For your work !