backstrokeapp / server

:swimmer: A Github bot to keep repository forks up to date with their upstream.
https://backstroke.co
MIT License
667 stars 62 forks source link

Several (if not all) of my repositories are not receiving the Pull Requests anymore #89

Closed evandrocoan closed 6 years ago

evandrocoan commented 6 years ago

For example: https://github.com/evandrocoan/UnitTesting is 10 commits behind the upstream, and there are not pull requests from Backstroke. Even backstroke is properly configured:

image

Recently the upstream has renamed from randy3k/UnitTesting to SublimeText/UnitTesting. Does it make a difference?

I also had clicked on the refresh button, but it keep spinning:

image

And accessing the ping URL https://api.backstroke.co/_59cdc241408205001... does nothing useful:

image

Should not accessing the ping URL https://api.backstroke.co/_59cdc241408205001... trigger the pull request creation?

1egoman commented 6 years ago

Recently the upstream has renamed from randy3k/UnitTesting to SublimeText/UnitTesting. Does it make a difference?

Try updating that. The pull request that backstroke is making returns this error code (head is the repository/branch that the pull request should pull changes from):

{"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}
evandrocoan commented 6 years ago

Thanks, it worked!

image

Backstroke should have send me a email announcing this, otherwise there is not point into using backstorke if it will fails silently when the upstream repository is renamed/transferred to another user.

1egoman commented 6 years ago

Backstroke should have send me a email announcing this

Good idea, but that's a pretty large feature. Backstroke has no infrastructure for that right now (and frankly, I don't have time to work on something like that right now). Always looking for contributions though.

It should definitely fail the link operation though if the head isn't valid in the pull request. Not sure why it doesn't do that currently.