backtrace-labs / crashpad

A fork of Crashpad with file attachment support and other improvements.
Apache License 2.0
100 stars 31 forks source link

CMAKE option to make MSVC use /MT and /MTd for Release and Debug builds respectively #16

Closed cjserio closed 2 years ago

cjserio commented 2 years ago

Right now if you follow the instructions "cmake -G "Visual Studio 16 2019" .." you end up with all of the projects using /MD and /MDd. I've been struggling to find a way to force the project to use /MT and /MTd for Release and Debug builds respectively.

vlussenburg commented 2 years ago

Thanks for the feedback! I'll follow up once we've discussed this.

vlussenburg commented 2 years ago

This may be useful: https://stackoverflow.com/questions/55302553/how-to-build-dynamic-shared-libraries-of-crashpad

cjserio commented 2 years ago

That seems to be for Ninja, not CMAKE. The ZIP file available on the bactrace.io for MSVC has a lib_MT and lib_MD folder. I was really just wondering how that lib_MT was built. What CMAKE options were used?

vlussenburg commented 2 years ago

Hello! Those are built pre-CMake. It will likely require massaging the CMake files so that those parameters are injected based on the environment, but we’ll have to discuss this internally in the next week(s). In the meantime, feel free to fork the repo and if you figure it out before us, to submit a PR!

On Sat, Sep 10, 2022 at 08:43 cjserio @.***> wrote:

That seems to be for Ninja, not CMAKE. The ZIP file available on the bactrace.io for MSVC has a lib_MT and lib_MD folder. I was really just wondering how that was built. What CMAKE options were used?

— Reply to this email directly, view it on GitHub https://github.com/backtrace-labs/crashpad/issues/16#issuecomment-1242744676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRM5LJUBKXAYACI4SS7JLV5SNB3ANCNFSM6AAAAAAQIGR4QQ . You are receiving this because you commented.Message ID: @.***>

cjserio commented 2 years ago

Pull request sent! 👍

vlussenburg commented 2 years ago

Thanks! We will review it soon!!