search

backtrace-labs / crashpad

A fork of Crashpad with file attachment support and other improvements.
Apache License 2.0
99 stars 33 forks source link

CMake fixes #29

Open janisozaur opened 1 year ago

janisozaur commented 1 year ago

This fixes compatibility with Ninja generator

KrzaQ commented 1 year ago

Thank you for your PR!

I'm out until 23.01, expect further response then.

janisozaur commented 1 year ago

ping

KrzaQ commented 1 year ago

I think we can't accept those changes as they are. Do they pose a problem for your build?

janisozaur commented 1 year ago

Yes - without those ninja doesn't work

janisozaur commented 1 year ago

Oh, now that I'm not on mobile I see the failed CI jobs. That's ok, the first commit ("Drop superfluous language from CMakeLists") is only a minor optimisation that works on my platform due to linking with system zlib, while in other cases you probably build your own copy? I can drop that, the only fix required is the other commit.

KrzaQ commented 1 year ago

Yeah, that'll do, but I need to figure out how to add Ninja to the runner - I'm having a fun time ;) https://github.com/backtrace-labs/crashpad/actions/workflows/main.yml