search

backtrace-labs / crashpad

A fork of Crashpad with file attachment support and other improvements.
Apache License 2.0
101 stars 31 forks source link

Explicitly set target linker language for compat CMakeLists.txt #33

Closed KrzaQ closed 1 year ago

KrzaQ commented 1 year ago

This fixes compatibility with CMake's Ninja generator

janisozaur commented 1 year ago

I've submitted https://github.com/backtrace-labs/crashpad/pull/34 as well

janisozaur commented 1 year ago

And removed the other commit from #29, it does pass with current CI setup

janisozaur commented 1 year ago

any updates?

KrzaQ commented 1 year ago

Hi, sorry for the delay! I expect to work on this (and hopefully be done) towards the end of this week.

KrzaQ commented 1 year ago

It looks like I finally got the tests working. I'll proceed with this today

janisozaur commented 1 year ago

It seems you will have to update the required jobs' names for this to be merge-able.