search

backtrace-labs / crashpad

A fork of Crashpad with file attachment support and other improvements.
Apache License 2.0
99 stars 33 forks source link

crashpad needs to offer zip of attachments #51

Open alecazam opened 1 year ago

alecazam commented 1 year ago

Archiving multiple attachments building an archive , or even compressing a text log file would be valuable. Our log files are all text, and Windows vs. SteamDeck zip compression should probably be inside the crash handler.

alecazam commented 1 year ago

And also being able to read deflated and archived files in Backtrace would complete the work. At least logs.

konraddysput commented 1 year ago

Windows vs. SteamDeck zip compression should probably be inside the crash handler.

Can you elaborate more on why? Right now we expect Crashpad to send what it gets. Our integration handles everything related to attachment changes. In our system when we want to see "log" we should see it as a log.

In addition to that you have a use case with zip attachments on Windows and steamDeck. How about, iOS, Mac, Android, how about Fushia, and other OS that also uses Crashpad?

Please keep in mind - we do not want to put more and more features in the crash reporting solution. Every kind of problem generated by the crash handler will cause data loss for the client. I have mixed feelings about this as an issue.

alecazam commented 1 year ago

We can dip and deflate on our end, but then Backtrace needs to display the unzipped or parts of an archive. My only point was that our text-based .log files are big (up to 1mb), and we'd like to compress them when a crash happens. Having every caller have to pull in zip libraries is redundant but if you want to leave it to the caller, then at least have Backtrace deal with decompress when viewing atttachments.

If I have Sky.log.zip, then I'd prefer to see that unzipped in Backtrace when I click on it without having to download it. Archiving multiple attachments would seem useful and simplify uploading multiple attachments to the server.