Closed JohnStrunk closed 3 years ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Merging #218 (7f6981a) into master (d7b436d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #218 +/- ##
======================================
Coverage 76.4% 76.4%
======================================
Files 9 9
Lines 1956 1956
======================================
Hits 1495 1495
- Misses 358 359 +1
+ Partials 103 102 -1
Impacted Files | Coverage Δ | |
---|---|---|
controllers/volumehandler.go | 67.4% <0.0%> (-1.2%) |
:arrow_down: |
controllers/replicationdestination_controller.go | 81.0% <0.0%> (+0.5%) |
:arrow_up: |
@JohnStrunk - I threw#219 up there as an example which is based on what they did with community operators
- so I like the big warning image - so it's obvious to users, maybe add that in?
and I think it would be beneficial to remove the rest of the readme...don't even give them a chance to read anything about the project until they click to the new link
And then after the final switch we can just archive as read-only
I'd do the same with helm readme and the index.rst - IMHO
I adjusted the main + helm readme, and I also added a banner to all the docs pages.
@screeley44 I think this is ready for another look
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JohnStrunk, screeley44
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Describe what this PR does The Scribe project is being renamed to VolSync. With that rename, the repo and docs are moving. This PR adds notices and points people to the new location.
Is there anything that requires special attention?
Related issues:
Related to #217