Closed screeley44 closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: screeley44
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@screeley44 I've got #218 for the redirects. Could you provide some feedback there? I'm holding that PR until we have a release of VolSync so that there is an installable Helm Chart
Merging #219 (64d2236) into master (d7b436d) will decrease coverage by
0.1%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #219 +/- ##
========================================
- Coverage 76.5% 76.4% -0.2%
========================================
Files 9 9
Lines 1956 1956
========================================
- Hits 1498 1495 -3
- Misses 356 357 +1
- Partials 102 104 +2
Impacted Files | Coverage Δ | |
---|---|---|
controllers/replicationsource_controller.go | 77.8% <0.0%> (-1.2%) |
:arrow_down: |
controllers/volumehandler.go | 68.6% <0.0%> (ø) |
|
controllers/rsync_common.go | 65.2% <0.0%> (+2.0%) |
:arrow_up: |
@screeley44: PR needs rebase.
Updating old repo readme to point to new volsync repo