multiarch support (arm64 specifically)

backube / snapscheduler

Scheduled snapshots for Kubernetes persistent volumes

https://backube.github.io/snapscheduler/

GNU Affero General Public License v3.0

262 stars 26 forks source link

multiarch support (arm64 specifically) #372

Open scoof opened 1 year ago

scoof commented 1 year ago

Describe the feature you'd like to have. We would like to be able to run snapscheduler on arm64. It seems like the Makefile already supports multiarch, so this should be a matter of using the docker-buildx target to build. I've been unable to figure out how/where images are built/published, so I can't make this change as a PR.

What is the value to the end user? (why is it a priority?) arm64 is generally cheaper, so a good option for running k8s workloads

How will we know we have a good solution? (acceptance criteria) When snapscheduler can run on arm64 nodes

scoof commented 1 year ago

@JohnStrunk anything I can do to help this along? Can you tell me how/where you build images, so I can PR that?

JohnStrunk commented 1 year ago

Sorry... this slipped through the cracks.

The images are build via GH actions here: https://github.com/backube/snapscheduler/blob/bbc0bb8a12d1ff6495850faddb42c389a5fabc47/.github/workflows/tests.yml#L84-L107

The built artifacts are then used in the e2e test matrix, and finally pushed to quay here: https://github.com/backube/snapscheduler/blob/bbc0bb8a12d1ff6495850faddb42c389a5fabc47/.github/workflows/tests.yml#L246-L290

Some thoughts...

Adjusting the build to be multi-arch should be pretty straightforward.
I'm not sure what to do about the testing. I guess for now, we just won't test the non-x64 images
Since the images get exported and re-imported, I'm not sure how difficult it will be to get that part working

bmgante commented 9 months ago

Really interested on this... What are the plans to turn ARM image available?

scoof commented 9 months ago

Really interested on this... What are the plans to turn ARM image available?

I don't really have the time to do this at the moment.

bmgante commented 9 months ago

When you have some time to do that pls just let me know