Open tssgery opened 8 months ago
I think the problem is here we want there to be an error as no sync to the destination is succeeding (since this repo was never synced to). Other users may think their replications are succeeding when in fact they are doing nothing if we ignore these types of errors.
Using the rclone mover with an S3 backend, My deployment flow is as follows:
This works well, except for when I add a new PVC definition. When I do that, step "1" above, the rReplicationDestination never exits successfully as there is no
permissions.facl
file within S3. The code at https://github.com/backube/volsync/blob/483b169f2939781480e79c185c4306fad235b9f1/mover-rclone/active.sh#L43 fails, causing the container to exit with a non-zero return code. K8s sees this, and reschedules the mover again and put it in an endless loop.Here is an example manifest that exhibits the issue (note that the
development/does-not-exist
bucket/folder does not exist):Expected behavior I was hoping that the rclone mover would detect that no files existed, the permissions.facl file not needed, and ignore it's absence
Actual results Described above