search

backube / volsync

Asynchronous data replication for Kubernetes volumes
https://volsync.readthedocs.io
GNU Affero General Public License v3.0
566 stars 65 forks source link

ReplicationDestination w/ restic should fail if a wrong encryption passphrase is detected #1138

Closed Ramblurr closed 7 months ago

Ramblurr commented 7 months ago

Describe the bug

If you (accidentally) set the wrong encryption passphrase and try to to a restore with a ReplicationDestination, then restic will error out with a wrong passphrase error, but the overall job completes successfully.

This is especially painful when trying to do DR with volume populator.

Steps to reproduce

  1. Try to restore a volume using the restic data mover, but specific the wrong encryption passphrase

Expected behavior

The restore job should fail.

Actual results The restore job completes, but no data was transferred, and if you see the restic log it complains the password was wrong.

Additional context

tesshuflower commented 7 months ago

I think this is a duplicate of https://github.com/backube/volsync/pull/1005.

Please reopen if you're still having this issue with the latest code - if you're on 0.8.0, the fix should be available in the v0.9.0 release (should release in March)

tesshuflower commented 7 months ago

Update: Actually we may be releasing a v0.8.1 in the next week or 2, which would also contain this fix.