Delete temp pvc

[tesshuflower]

Describe what this PR does

• New spec field cleanupTempDestinationPVC for ReplicationDestinations to allow deleting the temp/dynamically provisioned destination PVC at the end of a sync. Available for all movers (except syncthing which has no ReplicationDestination).
• New spec field (for restic only) cleanupCachePVC for ReplicationDestinations to allow deleting the cache PVC at the end of a sync.

Is there anything that requires special attention?

• Even though there's more code duplication, I did not put this field in the VolumePopulator so it's explicit when we call EnsureNewPVC() whether or not it should be marked as temporary or not.
• Struggling again with good names for these fields, particularly cleanupTempDestinationPVC....I left "Temp" in the name to try to indicate that if you set destinationPVC then this would not be cleaned up. Considered cleanupDynamicDestinationPVC but seems long.
• The wording of temp also gets a bit muddy, so I started referring it to a dynamically provisioned PVC in some places. Since normally we'd want to leave it around, but technically it is still "temporary" since we will clean it up when the ReplicationDestination is removed.

Related issues: Fixes: https://github.com/backube/volsync/issues/1158

[tesshuflower]

/retest

[tesshuflower]

/cc @JohnStrunk

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/backube/volsync/blob/main/OWNERS)~~ [JohnStrunk,tesshuflower] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.5%. Comparing base (e693289) to head (affccc3). Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/mover/restic/mover.go	80.0%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1388 +/- ## ======================================= + Coverage 67.3% 67.5% +0.1% ======================================= Files 57 57 Lines 5834 5841 +7 ======================================= + Hits 3931 3944 +13 + Misses 1615 1612 -3 + Partials 288 285 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/backube/volsync/pull/1388?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube) | Coverage Δ | | |---|---|---| | [controllers/mover/rclone/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frclone%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcmNsb25lL2J1aWxkZXIuZ28=) | `90.1% <100.0%> (+0.1%)` | :arrow_up: | | [controllers/mover/rclone/mover.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frclone%2Fmover.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcmNsb25lL21vdmVyLmdv) | `74.3% <100.0%> (ø)` | | | [controllers/mover/restic/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frestic%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcmVzdGljL2J1aWxkZXIuZ28=) | `91.2% <100.0%> (+0.1%)` | :arrow_up: | | [controllers/mover/rsync/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frsync%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmMvYnVpbGRlci5nbw==) | `91.6% <100.0%> (+<0.1%)` | :arrow_up: | | [controllers/mover/rsync/mover.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frsync%2Fmover.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmMvbW92ZXIuZ28=) | `77.9% <100.0%> (ø)` | | | [controllers/mover/rsynctls/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frsynctls%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmN0bHMvYnVpbGRlci5nbw==) | `91.1% <100.0%> (+<0.1%)` | :arrow_up: | | [controllers/mover/rsynctls/mover.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frsynctls%2Fmover.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmN0bHMvbW92ZXIuZ28=) | `74.2% <100.0%> (ø)` | | | [controllers/mover/syncthing/mover.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Fsyncthing%2Fmover.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvc3luY3RoaW5nL21vdmVyLmdv) | `83.5% <100.0%> (ø)` | | | [controllers/volumehandler/volumehandler.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fvolumehandler%2Fvolumehandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvdm9sdW1laGFuZGxlci92b2x1bWVoYW5kbGVyLmdv) | `56.3% <100.0%> (+0.2%)` | :arrow_up: | | [controllers/mover/restic/mover.go](https://app.codecov.io/gh/backube/volsync/pull/1388?src=pr&el=tree&filepath=controllers%2Fmover%2Frestic%2Fmover.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcmVzdGljL21vdmVyLmdv) | `82.6% <80.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/backube/volsync/pull/1388/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube)