backube / volsync

Asynchronous data replication for Kubernetes volumes
https://volsync.readthedocs.io
GNU Affero General Public License v3.0
602 stars 69 forks source link

rsync/rsync-tls volumeMode for replicationdestination #1394

Closed tesshuflower closed 2 months ago

tesshuflower commented 2 months ago

Describe what this PR does

For the ODF team, who want to use diskrsync and have the replicationdestination create a dynamic pvc for them in RBD scenarios.

Is there anything that requires special attention?

Related issues:

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.5%. Comparing base (5d307de) to head (5df899c). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1394 +/- ## ======================================= + Coverage 67.4% 67.5% +0.1% ======================================= Files 57 57 Lines 5838 5844 +6 ======================================= + Hits 3935 3947 +12 + Misses 1615 1612 -3 + Partials 288 285 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/backube/volsync/pull/1394?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube) | Coverage Δ | | |---|---|---| | [controllers/mover/rsync/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1394?src=pr&el=tree&filepath=controllers%2Fmover%2Frsync%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmMvYnVpbGRlci5nbw==) | `91.7% <100.0%> (+<0.1%)` | :arrow_up: | | [controllers/mover/rsynctls/builder.go](https://app.codecov.io/gh/backube/volsync/pull/1394?src=pr&el=tree&filepath=controllers%2Fmover%2Frsynctls%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvbW92ZXIvcnN5bmN0bHMvYnVpbGRlci5nbw==) | `91.2% <100.0%> (+<0.1%)` | :arrow_up: | | [controllers/volumehandler/new.go](https://app.codecov.io/gh/backube/volsync/pull/1394?src=pr&el=tree&filepath=controllers%2Fvolumehandler%2Fnew.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvdm9sdW1laGFuZGxlci9uZXcuZ28=) | `54.5% <100.0%> (+2.6%)` | :arrow_up: | | [controllers/volumehandler/volumehandler.go](https://app.codecov.io/gh/backube/volsync/pull/1394?src=pr&el=tree&filepath=controllers%2Fvolumehandler%2Fvolumehandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube#diff-Y29udHJvbGxlcnMvdm9sdW1laGFuZGxlci92b2x1bWVoYW5kbGVyLmdv) | `56.4% <100.0%> (+0.1%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/backube/volsync/pull/1394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube)
tesshuflower commented 2 months ago

/cc @JohnStrunk

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/backube/volsync/blob/main/OWNERS)~~ [JohnStrunk,tesshuflower] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment