Controller runtime and tools update

backube / volsync

Asynchronous data replication for Kubernetes volumes

https://volsync.readthedocs.io

GNU Affero General Public License v3.0

602 stars 69 forks source link

Controller runtime and tools update #1396

Closed tesshuflower closed 2 months ago

tesshuflower commented 2 months ago

Describe what this PR does

updates controller-runtime to v0.19.0 (commit from renovatebot)
This updates most k8s libs to v0.31.0
updates controller tools to v0.16.3 (old controller-gen doesn't work anymore with these updates), and generate manifests etc

Is there anything that requires special attention?

running make manifests does some optimization to consolidate the roles so roles.yml looks quite a bit different, but appears to be ok as far as I can tell.

Related issues:

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.4%. Comparing base (4c8eb2e) to head (654f648). Report is 7 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1396 +/- ## ======================================= - Coverage 67.5% 67.4% -0.2% ======================================= Files 57 57 Lines 5844 5844 ======================================= - Hits 3947 3941 -6 - Misses 1612 1615 +3 - Partials 285 288 +3 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/backube/volsync/pull/1396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=backube)

tesshuflower commented 2 months ago

/cc @JohnStrunk

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/backube/volsync/blob/main/OWNERS)~~ [JohnStrunk,tesshuflower] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment