openshift-ci[bot]
commented
1 month ago [APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: renovate-bot Once this PR has been reviewed and has the lgtm label, please assign screeley44 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
- **[OWNERS](https://github.com/backube/volsync/blob/main/OWNERS)**
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot]
This PR contains the following updates:
v1.20.4->v1.20.5Release Notes
prometheus/client_golang (github.com/prometheus/client_golang)
### [`v1.20.5`](https://redirect.github.com/prometheus/client_golang/releases/tag/v1.20.5): / 2024-10-15 [Compare Source](https://redirect.github.com/prometheus/client_golang/compare/v1.20.4...v1.20.5) We decided to revert [the `testutil` change](https://redirect.github.com/prometheus/client_golang/pull/1424) that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the [exact error message](https://redirect.github.com/grafana/mimir/pull/9624#issuecomment-2413401565). Going forward, we plan to reinforce our release testing strategy [\[1\]](https://redirect.github.com/prometheus/client_golang/issues/1646),[\[2\]](https://redirect.github.com/prometheus/client_golang/issues/1648) and deliver an enhanced [`testutil` package/module](https://redirect.github.com/prometheus/client_golang/issues/1639) with more flexible and safer APIs. Thanks to [@dashpole](https://redirect.github.com/dashpole) [@dgrisonnet](https://redirect.github.com/dgrisonnet) [@kakkoyun](https://redirect.github.com/kakkoyun) [@ArthurSens](https://redirect.github.com/ArthurSens) [@vesari](https://redirect.github.com/vesari) [@logicalhan](https://redirect.github.com/logicalhan) [@krajorama](https://redirect.github.com/krajorama) [@bwplotka](https://redirect.github.com/bwplotka) who helped in this patch release! 🤗 ##### Changelog \[BUGFIX] testutil: Reverted [#1424](https://redirect.github.com/prometheus/client_golang/issues/1424); functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. [#1645](https://redirect.github.com/prometheus/client_golang/issues/1645)Configuration
📅 Schedule: Branch creation - " 3-6 * 1-5" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.