volsync migration: resize existing pvc as per user request during create

backube / volsync

Asynchronous data replication for Kubernetes volumes

https://volsync.readthedocs.io

GNU Affero General Public License v3.0

587 stars 68 forks source link

volsync migration: resize existing pvc as per user request during create #149

Open vh05 opened 2 years ago

vh05 commented 2 years ago

Describe the feature you'd like to have.

If the user request for a PVC > the capacity of the existing PVC, PVC needs to be resized or error out.

What is the value to the end user? (why is it a priority?)

With this user will have the right capacity of storage for migration.

How will we know we have a good solution? (acceptance criteria)

The capacity request should match the resized PVC

vh05 commented 2 years ago

@JohnStrunk please review the feature

JohnStrunk commented 2 years ago

I assume this is specifically for the case where we're using copymethod Direct into an existing PVC.

Something like: If capacity is provided for the destination and the PVC already exists, the CLI can update the PVC's .spec.resources.requests.capacity to be the max of the current value and the requested capacity.

Caveats:

There is no guarantee that resize is possible (driver support, available system capacity)
Kube doesn't support shrinking volumes

vh05 commented 2 years ago

In such cases, we can error out telling that resize failed or shrinking not allowed