tesshuflower
commented
1 year ago You're correct that only specific env vars are passed through - the RCLONE_ ones are not. See https://github.com/backube/volsync/blob/ea2d597b7a5d9bf9976635b23a2590160cf421c9/controllers/mover/restic/mover.go#L335-L381
I think that to use rclone this is a bigger change than simply passing through env vars, as restic will also need to know the location of rclone (possibly other flags are required as well?). This wouldn't have been possible previously - but now that the movers are all consolidated into one volsync image, the rclone binary will now be present on the machine. Actually I looked and rclone is put into /usr/local/bin/rclone so maybe will already be present in the path so one less hurdle.
Would passing through all env vars that start with RCLONE_ be enough?
Rojikku
Describe the feature you'd like to have. I would like to be able to pass environmental variables to the mover pod.
What is the value to the end user? (why is it a priority?) Restic allows you to use rclone as a backup method, but there's not really an rclone config option unless you're using rclone. Rclone allows you to do a full config via variables
How will we know we have a good solution? (acceptance criteria) Ability to pass arbitrarily named ENV variables to mover pod so that restic/rclone will recognize them.
Additional context Example I believe I configured that correctly, but I think the issue is that I took "Variables will correspond" from the docs too literally...and it doesn't just pass through everything.
Honestly, the more I look at this, the more I'm confused why it doesn't work. RESTIC_PASSWORD and RESTIC_REPOSITORY are both environment variables... Did you MANUALLY pass them through instead of passing through all portions of the secret as variables as a blanket? Pretty sure a blanket pass through would work fine for this use case. Honestly, either way. I'd be happy with anything as long as I can pass through my RCLONE config options.