backwardsEric / hengband

Hengband for macOS
https://backwardseric.github.io/hengband/
2 stars 0 forks source link

Artifacts with Japanese descriptions but no English descriptions #12

Open backwardsEric opened 3 years ago

backwardsEric commented 3 years ago

These artifacts have Japanese descriptions but do not have English descriptions in both 2.2.1 and 3.0.0 (ones struck through have picked up descriptions since this issue was opened):

backwardsEric commented 3 years ago

A recent change adds two more to the list (apparently brought over from Xangband):

backwardsEric commented 3 years ago

This pull request, https://github.com/hengband/hengband/pull/401 , took care of the descriptions for 'Icingdeath' and 'Twinkle'.

backwardsEric commented 2 years ago

A recent change adds one more to the list, Longbow of Diana (from Nethack).

backwardsEric commented 2 months ago

Yasaka-no-Magatama also does not have an English description. It is present in 2.2.1 and 3.0.0. In 2.2.1 it does not have Japanese text, but it picked up Japanese text in April, 2021.

backwardsEric commented 1 week ago

The upstream pull request https://github.com/hengband/hengband/pull/4469 (with corrections in 9ca5ebcaaba77318579eb32ec0838fd66f3614b5 ) adds English descriptions for Yasaka-no-Magatama, Hrunting, Tailbiter, of Giles, Quickthorn, Littlethorn, Excalibur, Falcon Sword of Destruction, and Bastard Sword of Eowyn. https://github.com/backwardsEric/hengband/commit/012da001ff22689920b800a7249c138b6e1ff493 ports those descriptions to the 2.2.1 branch.