search

bacongobbler / azure-blob-storage-upload

Uploads assets to Azure Blob Storage
Other
56 stars 24 forks source link

bug: sync enabled by default #6

Closed bacongobbler closed 3 years ago

bacongobbler commented 4 years ago

After merging the sync flag functionality in https://github.com/bacongobbler/azure-blob-storage-upload/commit/9b68613240aad40c44b2883226bcf29958f97ef9, if the flag is not set in the workflow yaml file, the sync flag is enabled. Setting sync: false works around this, however it would be better to disable sync by default. That way files are preserved between uploads.

hayer commented 4 years ago

Can confirm. A fix would be great, but the workaround is quite simple.

bacongobbler commented 3 years ago

sync is now required as of #10. Therefore each user must opt into enabling or disabling the sync flag which resolves this issue.