search

bacongobbler / confd

Manage local application configuration files using templates and data from etcd
MIT License
21 stars 11 forks source link

etcd as the backend, prefix option will overwrite prefix item in template file in version 0.12 #3

Closed danielzhanghl closed 7 years ago

danielzhanghl commented 7 years ago

this is an issue I reported to Kelsey Hightower' CONFD, but it seems not active any more, and report here, https://github.com/kelseyhightower/confd/issues/516

highlight of the issue:

it's a change on the new version, the prefix is not a joint one, instead, the prefix in template file will be overwritten by confd profile, which cause the configuration file failed with this new version. code as below:

resource.go: NewTemplateResource, new version:

if config.Prefix != "" {
        // tr.Prefix = config.Prefix
        if tr.Prefix == "" {
                tr.Prefix = config.Prefix

but in previews version, it's a joint prefix as below: tr.prefix = filepath.Join("/", config.Prefix, tr.Prefix)

bacongobbler commented 7 years ago

I'm no longer maintaining this fork. Please make the change upstream. There are new maintainers taking over development of confd so this fork is no longer needed.

NStanleyZhang commented 7 years ago

could you let us know which one should i follow up?

bacongobbler commented 7 years ago

upstream is at https://github.com/kelseyhightower/confd.