baconjs / bacon.js

Functional reactive programming library for TypeScript and JavaScript
https://baconjs.github.io
MIT License
6.47k stars 330 forks source link

Update Bacon.js on baconjs.github.io #460

Closed BlackYoup closed 9 years ago

BlackYoup commented 9 years ago

It seems that the 0.7.28 version broke some stuff, but it's the version used on your website at http://baconjs.github.io/

Could you update it ? I enjoy trying Bacon on this page but some functions that use "timers" (e.g. sequentially) are broken :(

Thanks :)

raimohanska commented 9 years ago

Updated to 0.7.30.

What is/was actually broken? I didn't quite get it.

BlackYoup commented 9 years ago

Thanks

Well, I thought the 0.7.28 version was broken, but it seems this is something else, because it still happens with the 0.7.30 on your website.

Pictures will be better :

A test on your website at http://baconjs.github.io/ on Website

A local test local test

Look at the seconds when values are displayed. On your website, there is almost no delay between values, on my local tests, there is 1 sec between them.

It happens on firefox (nightly and stable) and google chrome (couldn't check for others). And this is not the only function: Bacon.interval(1000, 1).onValue(x => console.log(x)); gives me no values (no output).

Hope it helps

phadej commented 9 years ago

On the page we tinker with scheduler, to do marble graphs. IIRC we don't untinker

raimohanska commented 9 years ago

What @phadej said. Thanks for your good report anyway, @BlackYoup!

It's btw a bit suboptimal to only be able to set the scheduler in a global scope...

BlackYoup commented 9 years ago

No problem. Feel free to close this issue :-)

phadej commented 9 years ago

I'll try to find time next week to check if we can undo global scheduler changes. I enjoy trying Bacon on the site myself :)

raimohanska commented 9 years ago

Btw I updated the "learn bacon" site http://learn-bacon.herokuapp.com/ that was previously known as "bacon-game". I mostly improved the visuals and usability. There's a proper editor now, too.

BlackYoup commented 9 years ago

Thanks @phadej ! Nice @raimohanska, didn't know about this, this is just what I need !

BlackYoup commented 9 years ago

Hi guys, any news on this ? :)

phadej commented 9 years ago

Not yet :( totally forgot this issue. Sorry

phadej commented 9 years ago

Resolved in https://github.com/baconjs/baconjs.github.io/commit/d5bfb9168d270f05fd597437183be972ecba3cc9

screen shot 2015-01-07 at 11 48 58

BlackYoup commented 9 years ago

Thanks !