search

baconjs / bacon.js

Functional reactive programming library for TypeScript and JavaScript
https://baconjs.github.io
MIT License
6.47k stars 331 forks source link

export Bacon.isProperty(Observable) #808

Closed semmel closed 1 year ago

semmel commented 1 year ago

For their different behaviour (i.e. having a "current" value or not), downstream code needs to inspect the type of observable it is dealing with.

raimohanska commented 1 year ago

Sure, makes sense!

raimohanska commented 1 year ago

@semmel I'd like to make you a contributor on the Bacon.js NPM package as well so you could publish the next version on NPM. Do you have an npm username?

raimohanska commented 1 year ago

My apologies for being a very bad maintainer for years already - I'd be super happy if more active folks like you would take charge on this project.

semmel commented 1 year ago

@raimohanska Thanks for merging!

@semmel I'd like to make you a contributor on the Bacon.js NPM package as well so you could publish the next version on NPM. Do you have an npm username?

It's semmel as well.

My apologies for being a very bad maintainer for years already - I'd be super happy if more active folks like you would take charge on this project.

No need to apologise, it's all voluntary commitment. In that sense, I cannot promise much regarding maintenance. Perhaps some tweaks here and there — certainly I won't fight the intricacies of TypeScript if that comes up in an issue.

raimohanska commented 1 year ago

Invited you as an owner on NPM. Technically you can merge your own PRs as well I think - but having a second opinion and code review is often a good idea of course. I'll try to be more responsive towards issues and PRs even though I'm unlikely to resume a more active development role for Bacon.js.