search

baconjs / bacon.matchers

Matchers API for Bacon.js
MIT License
21 stars 6 forks source link

New matchers, possibility to add matchers that take 2 parameters #3

Closed jliuhtonen closed 10 years ago

jliuhtonen commented 10 years ago

I wrote a few new matchers that were relevant to my interests:

The last two required introducing apply3 function for making it possible for matchers to take 2 parameters.

Init function returned function "where" instead of Bacon, that has also been fixed.

README updated accordingly, also added IDEA files to gitignore.

Since I did not have time to add proper tests with Coffee to the project, I wrote a few quick Mocha tests for added functionality with vanilla JS that can be converted to Coffee later if needed. They are in their own branch if you are interested: https://github.com/jliuhtonen/bacon.matchers/blob/mocha-tests/test/test.js

raimohanska commented 10 years ago

Thanks man!

Pls make PR for tests too. I'm no coffeescript fanboy, javascript goes just fine. Test-running instructions in readme would be great too!

jliuhtonen commented 10 years ago

Thanks for a new release!

I'll make a PR for the tests later. Looking at the tests again I just noticed a common pitfall of not calling done after asserting in a callback, so I'll fix that first. Duh. :)