search

baconpaul / BaconPlugs

My plugins for VCVRack, which you may enjoy.
GNU General Public License v3.0
71 stars 11 forks source link

Update ci definition #86

Closed qno closed 1 year ago

qno commented 1 year ago

https://github.com/baconpaul/BaconPlugs/blob/22bbc5d7e32dd5abec0183b12b519f613dd06d8c/.github/workflows/build-plugin.yml#L1

Hi,

you should update the build-plugin.yml definition. Just copy the one from surge-rack, which is updated to use always the latest Rack SDK Docker container.

baconpaul commented 1 year ago

https://github.com/baconpaul/BaconPlugs/commit/174614071d1965ce2f21feaa64842c3f781eae22

I did that exactly 4 days ago. Is there something I missed?

qno commented 1 year ago

OK - I see now, it is correct. I don't know what I saw today morning.

Nevermind ...

baconpaul commented 1 year ago

The library version uses the old one

by the way thank you so much for all your efforts here. Super valuable!

qno commented 1 year ago

Thank you, no problem.

I also need to thank you for working on the awesome Surge Rack plugin!

baconpaul commented 1 year ago

I literally wouldn't have started the work if you didn't help me get the make system going back in the summer. So thank you!