Fix to QC function - Githubissues

bacpop / PopPUNK

PopPUNK 👨‍🎤 (POPulation Partitioning Using Nucleotide Kmers)

https://www.bacpop.org/poppunk

Apache License 2.0

89 stars 18 forks source link

Closed nickjcroucher closed 3 years ago

nickjcroucher commented 3 years ago

Correcting a small omission in the QC filtering.

johnlees commented 3 years ago

@nickjcroucher Is this ready for review/merge?

nickjcroucher commented 3 years ago

Yep, this should be good to review, thanks!

johnlees commented 3 years ago

Slightly modified so that:

set variable in ref v query intersection is reused rather than recalculated
Use join rather than string conversion for output (to control delimiters)
Corrected error exit call
Use simplified duplicate finding code, which is inline rather than in a function (as function isn't currently reused)