Closed johnlees closed 1 year ago
Base: 82.78% // Head: 82.53% // Decreases project coverage by -0.25%
:warning:
Coverage data is based on head (
a244364
) compared to base (d83ac94
). Patch coverage: 82.18% of modified lines in pull request are covered.:exclamation: Current head a244364 differs from pull request most recent head dda5bd8. Consider uploading reports for the commit dda5bd8 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Note this also fixes the countmin table -- only one hash was being used rather than four
Adds generics over
u64
to allow use ofu128
when 31 < k <= 63. More fiddly than I expected, but main parts are:RevComp
adds all the needed integer traits, and adds specialisations for the reverse_complement function and other base type coversions.u64
. If that errors, thenu128
is tried. This necessitated many of the main functions inlib.rs
being lifted out and made generic.TODO:
cargo test
-- fix existing codecargo test
-- add new tests for k=63cargo clippy
-- fix lintcargo fmt
-- before merge