search

bacpop / ska.rust

Split k-mer analysis – version 2
https://docs.rs/ska/latest/ska/
Apache License 2.0
56 stars 4 forks source link

Add optional output filename option `-o` to `ska weed`. #55

Closed tmaklin closed 9 months ago

tmaklin commented 9 months ago

Adds an optional output filename argument to ska weed. Default behavior still is to overwrite the input but the new argument adds some flexibility. This may be useful to people who don't want to overwrite their inputs.

johnlees commented 9 months ago

Seems like a very sensible addition – not sure why the tests aren't running though, maybe some github branch thing I've set up wrong. I've added you as a collaborator now if you want to use an internal branch. You also need to bump the version number to pass that test. If you don't have time I can sort this out in the next few weeks (travelling for a while)

tmaklin commented 9 months ago

thanks, I'll give it a try

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.10% :warning:

Comparison is base (7237159) 92.51% compared to head (1a061af) 92.42%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #55 +/- ## ========================================== - Coverage 92.51% 92.42% -0.10% ========================================== Files 16 16 Lines 2192 2152 -40 ========================================== - Hits 2028 1989 -39 + Misses 164 163 -1 ``` | [Files Changed](https://app.codecov.io/gh/bacpop/ska.rust/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop) | Coverage Δ | | |---|---|---| | [src/cli.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL2NsaS5ycw==) | `73.96% <50.00%> (-0.45%)` | :arrow_down: | | [src/lib.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL2xpYi5ycw==) | `80.94% <100.00%> (-0.86%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/bacpop/ska.rust/pull/55/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.