bacpop / ska.rust

Split k-mer analysis – version 2
https://docs.rs/ska/latest/ska/
Apache License 2.0
70 stars 4 forks source link

Fix for ska delete #58

Closed johnlees closed 1 year ago

johnlees commented 1 year ago

Silly mistake in the loop that does the deletion which I'm surprised wasn't caught by the tests, maybe need to review these.

Closes #57

codecov[bot] commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4eb1446) 92.42% compared to head (247b24d) 92.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== + Coverage 92.42% 92.50% +0.08% ========================================== Files 16 16 Lines 2152 2176 +24 ========================================== + Hits 1989 2013 +24 Misses 163 163 ``` | [Files](https://app.codecov.io/gh/bacpop/ska.rust/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop) | Coverage Δ | | |---|---|---| | [src/generic\_modes.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL2dlbmVyaWNfbW9kZXMucnM=) | `100.00% <ø> (ø)` | | | [src/merge\_ska\_array.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL21lcmdlX3NrYV9hcnJheS5ycw==) | `99.65% <100.00%> (+0.77%)` | :arrow_up: | | [src/ska\_ref.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL3NrYV9yZWYucnM=) | `96.22% <100.00%> (-0.02%)` | :arrow_down: | | [src/lib.rs](https://app.codecov.io/gh/bacpop/ska.rust/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bacpop#diff-c3JjL2xpYi5ycw==) | `80.63% <85.71%> (-0.31%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.