Suggestion: consistent output suffixes in ska weed

bacpop / ska.rust

Split k-mer analysis – version 2

https://docs.rs/ska/latest/ska/

Apache License 2.0

59 stars 4 forks source link

Suggestion: consistent output suffixes in ska weed #64

Closed rderelle closed 7 months ago

rderelle commented 9 months ago

Not an issue per se.

I noticed that the commands 'build' and 'merge' seem to systematically add a '.skf' extension to the output name file while the command 'weed' does not.

For instance, the command 'ska build -o name_file.skf' generates a file 'name_file.skf.skf' while the command 'ska weed -o name_file.skf' generates a file 'name_file.skf'.

johnlees commented 9 months ago

Good spot, I will improve this in the next release – I think the weed behaviour is better (checking for .skf and not adding if already there)