bacpop / unitig-counter

Uses cDBG to count unitigs in bacterial populations
GNU Affero General Public License v3.0
13 stars 2 forks source link

Make Boost detection more reliable; strip symbols for Release builds #7

Closed santeripuranen closed 4 years ago

santeripuranen commented 4 years ago

Here are a three CMake/build-related suggestions:

1) use the BOOST_ROOT environment variable from the host shell if it was set. This way it's more likely that the particular version of Boost that the user intends to use is actually detected.

2) set up Boost before GATB. Compilation of GATB failed on two of the four systems that I have tested on, one because of 1) where it managed to find an ancient version of Boost supplied by the system, and the other because it failed to locate Boost altogether. BOOST_ROOT (in the shell) pointed to the correct location in both cases.

3) Strip symbols to create a smaller binary in Release mode. The binary tends to become bloated when one links everything statically, including libstdc++.

Cheers, Santeri