search

badabing2005 / PixelFlasher

Pixel™ phone flashing GUI utility with features.
GNU General Public License v3.0
1.34k stars 113 forks source link

some worry with patch with kernelsu lkm #181

Closed goattc closed 7 months ago

goattc commented 7 months ago

Creating a patch ...

| |/ / | / || | | | | ' // \ '| ' \ / \ _ | | | | | . \ / | | | | | / |__) | || | ||_\|| || |_|_||____/ \/

❌ 2024-03-29 13:02:56 ERROR: Could not get file content: /data/local/tmp/pf_patch.log Aborting ...

Aborting ...

badabing2005 commented 7 months ago

@goattc Please provide a support file

goattc commented 7 months ago

support_2024-04-01_13-20-17.zip

badabing2005 commented 7 months ago

Thanks for the support file. When I released the KernelSU LKM support, at the time the latest version of KernelSU was v0.9.2:11682 (which I still had on my test phone) That version of KernelSU, generated a patched file named as follows: kernelsu_boot_20240401_125447.img

- Output file is written to
- /data/local/tmp/pf/assets/kernelsu_boot_20240401_125447.img

You're using a newer version: v0.9.2-55-g7fe0732:11737 Which has change the output file name format to: kernelsu_patched_20240329_045616.img

- Output file is written to
- /data/local/tmp/pf/assets/kernelsu_patched_20240329_045616.img

If you look at the script PixelFlasher generates and then runs, it has the following line.

cp kernelsu_boot_* /storage/emulated/0/Download/${PATCH_FILENAME}

Which obviously fails with the newer version. I'll have an update to look for either format, but I surely hope the developer doesn't pull the rug on me and change again.

badabing2005 commented 7 months ago

@goattc Where did you get that version of yours? The published version is still the same one that I've tested with.

goattc commented 7 months ago

Tg group : https://t.me/KernelSU_group

badabing2005 commented 7 months ago

Sorry I don't use TG. The changes are easy, but I will only add them when an official release outputs in that format.

badabing2005 commented 7 months ago

This is fixed in PixelFlasher 6.9.1.2

successtheman commented 4 months ago

This issue seems to be happening again on the latest build of PixelFlasher, I had to patch the image manually to get kernelsu to install

badabing2005 commented 4 months ago

Support file ???

XdekHckr commented 4 months ago

Support file ???

Boring. support_2024-07-03_22-48-47.zip It is not even detecting that magisk app is installed (does phone need to be rooted to detect app? If not then it should work, lol) support_2024-07-03_23-02-19.zip

badabing2005 commented 4 months ago

Support file ???

Boring. support_2024-07-03_22-48-47.zip It is not even detecting that magisk app is installed (does phone need to be rooted to detect app? If not then it should work, lol) support_2024-07-03_23-02-19.zip

What's boring?

You have multiple issues my friend, have you even read the guide? It is not detecting Magisk app because you have the wrong package name set. It is not detecting root, because you haven't granted root permission to shell You also seem to have internet connection issues.

XdekHckr commented 4 months ago
  1. Well if I have wrong package then you made it wrong, because it's default and magisk was installed via pixel flasher using adb.
  2. I don't have root so nothing to grant
  3. I have updated platform tools and restarted pc and it started to work So I think you was not right 100%
badabing2005 commented 4 months ago

  1. Well if I have wrong package then you made it wrong, because it's default and magisk was installed via pixel flasher using adb.

    1. I don't have root so nothing to grant

    2. I have updated platform tools and restarted pc and it started to work So I think you was not right 100%

You really have to learn how to read the guide. If you Magisk is installed and it is not detected, you have either hidden the Magisk and not updated the package name in the settings, (PF has no way of knowing the hidden package name) Or you have switched Magisk flavors (example kitsune to offical Magisk or vice versa or any other flavor that is available) but kept the package name set to the old.

Like I said, you have multiple issues, that was not the only one.

Glad you sorted it out.