search

badaix / snapdroid

Snapcast client for Android
GNU General Public License v3.0
127 stars 25 forks source link

Fixes for Android Q #17

Closed derWeihnachtsmann closed 4 years ago

derWeihnachtsmann commented 4 years ago

Binary cannot be loaded from "external" anymore.. :( fixes #16

badaix commented 4 years ago

where are the binaries coming from?

derWeihnachtsmann commented 4 years ago

where are the binaries coming from?

I just copied them from /src/main/assets/bin. I had some struggle with android Studio, sorry for the misconvenience there.

badaix commented 4 years ago

Thanks,

renaming the binaries to libXXX.so is ugly! But I googled and on reddit they came up with the same workaround.

This means that we won't need this copy and setup stuff anymore?

In MainActivity.java

        new Thread(new Runnable() {
            @Override
            public void run() {
                Log.d(TAG, "copying snapclient");
                Setup.copyBinAsset(MainActivity.this, "snapclient", "snapclient");
                Log.d(TAG, "done copying snapclient");
            }
        }).start();

And all of those CopyAsset and CopyBinAsset in Setup.java?

badaix commented 4 years ago

After following GitHub's manual merge instructions because of a conflict, I get: Unsupported Modules Detected: Compilation is not supported for following modules: libs, libsnapcast. Unfortunately you can't have non-Gradle Java modules and Android-Gradle modules in one project.

badaix commented 4 years ago

@derWeihnachtsmann thanks, it's now merged and builds. Because of my formerly unpushed changes, there was a merge conflict, and now you are for some reason not listed as contributor. Sorry for that, I don't know how to fix this.