badamrussell / Jamming

codecademy capstone Project 3 Jamming
0 stars 0 forks source link

Summary #4

Open mp1pro opened 6 years ago

mp1pro commented 6 years ago

The project does not run. There are a lot of redundancies and errors. I am not sure how to address most of the errors. For example,import PropTypes from 'prop-types';. I do not see any class or file called prop-types. Also why are the files named TrackList.template.js. I do not understand why you did not create 'react classes' given that you imported the React class hereimport React from 'react';. To compare code check out this repo; https://github.com/mp1pro/jamming

badamrussell commented 6 years ago

prop-types is an npm package. it is found in the package.json file under dependencies. It used to be a part of the React core, but they moved it out in one of their later 15.x updates.

I tried splitting the logic into separate files. one file had the simple display logic. If it needed state or any additional logic, I tried to separate them into separate files. So files with template suffix are really simple and have no business logic, while the presenter component (if present) handles the business logic.

When the React component is simple and does not need any of the life-cycle methods or internal state, instead of creating a class, you can just create it as a function. I supposed React is not needed as an import in that case. Although you might need it, if you are using JSX. I'd have to look into that one.

mp1pro commented 6 years ago

Publish the site on surge.sh (or similar) as a proof of concept. I would be only able to troubleshoot if react classes are used. For further support please contact advisers or customer support at http://codecademy.com