badarshahzad / JFX-Browser

JFx Browser is a multi tab browser. In its first version HTML to PDF, Downloading , History, Bookmarks and Account creation facility available. We are not still working on this project.
MIT License
200 stars 48 forks source link

Each New Tab not consists web engine and web view #11

Closed badarshahzad closed 7 years ago

badarshahzad commented 7 years ago

Well, today was the actually the headache day. After spending much time what we concluded is we added the new tab feature but as mention by Sir Sarmad we will feel the pain during multi tabs.

any idea I think we have to plan a meeting for this issue right? :+1:

Project

// --------------------------------------------------------TabPane---------------------------------------------

        //----------------------just put tabpane in vbox as to add new tab button on click new tab pop up

        tabpane.getSelectionModel().selectedItemProperty().addListener(
                new ChangeListener<Tab>() {
                    @Override
                    public void changed(ObservableValue<? extends Tab> ov, Tab t, Tab newSelectedTab) {
                        if(newSelectedTab==addNewTab){

                            /*@@@@@@@@@@@@@@@@@@@@@@@@@@@@@--Problem---@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
                             * Problem is when If I will put previous navigation bar in new pane then
                             * it works for previous listeners? Here his a debate start how we will do it?
                            */
                            //New Tab new rowser pane
                            WebView browser = new WebView();
                            WebEngine webEngine1 = browser.getEngine();
                            webEngine1.load("http://www.google.com");
                            BorderPane pane = new BorderPane();
                            pane.setTop(navigationBar);
                            //pane.setCenter(browser);

                            Tab tab = new Tab();
                            tab.setText("1 Tab");
                            tab.setContent(new Label("Message "));
                            tab.setContent(pane);

                            tab.getStyleClass().addAll("tab-pane");
                            final ObservableList<Tab> tabs = tabpane.getTabs();
                            tabs.add(tabs.size()-1,tab);
                            tabpane.getSelectionModel().select(tab);
                            //System.out.println("Now Size"+tabs.size());

                        }
                    }
                }
            );

@naeemkhan12 @Hassankhan2015 @sanaullahkhan1234 @Shoaibkhan786 @RamzanShahidkhan

badarshahzad commented 7 years ago

We have solved this I'm gonna close this one too! :100: