search

badarshahzad / JFX-Browser

JFx Browser is a multi tab browser. In its first version HTML to PDF, Downloading , History, Bookmarks and Account creation facility available. We are not still working on this project.
MIT License
200 stars 48 forks source link

project structure change for yml but still no improvements #63

Open badarshahzad opened 6 years ago

badarshahzad commented 6 years ago

Guys, I have tried but still no improvements in maven build error what to do now? :walking_man: screenshot from 2017-11-29 02 40 25

badarshahzad commented 6 years ago

:wave: well they email us we are failed again to build in maven :smile: screenshot from 2017-11-29 02 42 14

goxr3plus commented 6 years ago

The project structure now is lit fire 🔥 good work.

goxr3plus commented 6 years ago

@badarshahzad Because I am away from any computer, can you try and run locally on your computer in the same folder as the pom. xml file on the terminal or command prompt the command mvn clean package.

It should run all the way correctly and produce the target folder along with browser jar file and libraries.

badarshahzad commented 6 years ago

yeaaah! Build Success! :100: screenshot from 2017-11-29 03 12 31

badarshahzad commented 6 years ago

@goxr3plus don't you notice the total time :+1:

goxr3plus commented 6 years ago

@badarshahzad Something seems wrong here. I don't see anywhere in the picture the procedure of copying the required dependencies to the external folder.

goxr3plus commented 6 years ago

@badarshahzad Do you see JFX-Browser_lib folder inside the target folder side by side the jar file.

If yes does it contains the libraries?

badarshahzad commented 6 years ago

@goxr3plus Nope, I didn't find any lib directory.

goxr3plus commented 6 years ago

@badarshahzad Yep because you did run mvn clean now I have seen it :).

Instead try and run mvn clean package

I am preparing Maven tutorials on YouTube.

badarshahzad commented 6 years ago

This is the result after after run mvn clean package error

What do you think about gradle? Don't we add gradle dependance?

goxr3plus commented 6 years ago

It fails because you need Maven 3.0.0 and above. I have made it like this :)

Gradle is like Maven but different. We use either the one or the other.

Actually there are many systems. Google Maven VS Gradle VS Ivy VS Ant The most recent is Gradle which come to resolve Maven problems and more. Actually it is written in Groovy, which is a very beautiful language.

It is a little bit more complex, I am not very experienced with Gradle yet :).