badarshahzad / JFX-Browser

JFx Browser is a multi tab browser. In its first version HTML to PDF, Downloading , History, Bookmarks and Account creation facility available. We are not still working on this project.
MIT License
200 stars 48 forks source link

Java 9 Compatibility #70

Open pdemanget opened 6 years ago

pdemanget commented 6 years ago

Could you upgrade the dependency of JFoenix version for java9 Compatibility? see bug: https://github.com/jfoenixadmin/JFoenix/issues/365

Of course, if you want to keep java8 compatibility, you have to maintain 2 branches.

Here is the patch that works for me in JDK9:

diff --git a/build.gradle b/build.gradle index baadc1f..abb3e8a 100644 --- a/build.gradle +++ b/build.gradle @@ -19,7 +19,7 @@ jar { dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' compile group: 'org.xerial', name: 'sqlite-jdbc', version: '3.7.2'

goxr3plus commented 6 years ago

Great i will do it! :)

I need some testing first.

goxr3plus commented 6 years ago

It's done :). You can download it for Java 9.