search

badasintended / badpackets

multiplatform packet api
https://bai.lol/badpackets
Apache License 2.0
22 stars 4 forks source link

[Minor] Crash on JoinMultiPlayerScreen while idle #18

Open KyneSilverhide opened 1 month ago

KyneSilverhide commented 1 month ago

Minecraft Version: 1.20.1 Forge Version: 47.3.10 Badpacket version : 0.4.3

Logs: https://gist.github.com/KyneSilverhide/3e79c55a1910040c8078d5c1a734024a

Steps to Reproduce:

  1. Launch the game
  2. Join a server
  3. Logout, and wait on the server list screen
  4. The game will crash after ~30sec.

Description of issue: It's not really problematic, but it seems the game crashes while handling some kind of timeout. I only have a single server, and I can join perfectly. Even if the game list the server as "unreachable"

371840686-fa60aee9-3d2b-4806-835d-30dca3d9bf18

deirn commented 1 month ago

Just to make sure, since Bad Packets doesn't touch m_7026_ in the mixin, does it happens if you remove Bad Packets?

KyneSilverhide commented 1 month ago

No, it only happens with Bad Packets. No mods at all : no crash All mods, including bad packet : crash every time All mods, BUT bad packets : no crash

deirn commented 1 month ago

I found this, https://github.com/Aizistral-Studios/No-Chat-Reports/issues/481. Can you try without No Chat Reports?

KyneSilverhide commented 1 month ago

Hmm, strange. I disabled No Chat Reports, and the game didn't crash. (as expected...) Then I re-enabled BacPackets (same 0.4.3 version) and No Chat Reports and... no crash. but this time the MOTD is also properly shown on the server list.

image

That's strange, but it's working, si I think you can close the issue. Thanks !