search

badboy / iso8601

Parsing ISO8601 dates using nom
https://docs.rs/iso8601/
MIT License
74 stars 22 forks source link

Added support for ISO 8601 Durations #24

Closed zoewithabang closed 5 years ago

zoewithabang commented 5 years ago

I also grouped some of the utility functions together and renamed some of the internal functions in parsers.rs to differentiate between date, time and duration parsing.

Let me know if there are desired changes, I haven't used nom before so there might be some more ergonomic ways of parsing than I came up with! 😄

Closes #23

zoewithabang commented 5 years ago

I reworked the duration_datetime implementation a bit to be able to fully parse datetimes that are positive only, which seems to match the spec.

The CI build appears to be having some issues connecting to GitHub but I think everything should be working.

Thanks for the thorough review, I can definitely work on improving my technical documentation skills in future! 😄