search

baddstats / polyclip

R package polyclip: a port of the Clipper library for polygon geometry
19 stars 6 forks source link

Undo reversion of .Call() arguments #10

Closed richierocks closed 6 years ago

richierocks commented 6 years ago

You may recall that ployclip is used in the Spatial Statistics in R DataCamp course. Last year, when we were making that course, I made some updates to polyclip's .Call() routines to add a PACKAGE argument. This was necessary to make the package work on our platform.

I've just been making some updates to that course and unfortunately, the latest version of polyclip doesn't work. It look like the changes to .Call() were reverted back in March.

https://github.com/baddstats/polyclip/commit/f1fff8cc3cf1ea0bf4a6f968d883dbd28881353a#diff-c0145812160455f0558c81a96c08e975

Is there a reason for this? Are you happy to undo the reversion?

baddstats commented 6 years ago

Incompetence is the reason!! It will be fixed asap

baddstats commented 6 years ago

Done