search

baddstats / polyclip

R package polyclip: a port of the Clipper library for polygon geometry
19 stars 6 forks source link

Allow building against system copy of clipper. #8

Closed QuLogic closed 6 years ago

QuLogic commented 6 years ago

This change looks a bit bigger than it really is because of the re-indenting within the if. Try viewing without whitespace changes to see the effective change.

With this, I can build against the system copy on Fedora, which is 6.4.2.

codecov-io commented 6 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files           6        6           
  Lines        2970     2970           
=======================================
  Hits         1884     1884           
  Misses       1086     1086

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1fff8c...430eb19. Read the comment docs.

baddstats commented 6 years ago

Thank you very much!

baddstats commented 6 years ago

@QuLogic, some users are now reporting problems with installation of polyclip against a system copy of the polyclipping library. See open issues in polyclip repository. Can you help?