npm ci fails in GHA when upgrading to latest v12.0.1

richardszanyi-kasa commented 2 years ago

After upgrading to latest version of the package, and resolving some issues - in CI when using npm ci it throws this error. Then I checked the package-lock, and the only entry with esbuild is this package, at least in peerDependencies. Also tried to regenerate package-lock, deleted both node_modules and package-lock as well, nothing helps. If you have any advice, or think this is not a bug, but a user error please let me know, and you can close this ticket as well. :) Thank you kindly.

Current behavior

Desired behavior

npm ci in CI works.

Versions

Cypress version: 10.6.0
Preprocessor version: 12.0.1
Node version: 17.9.1

Checklist

[X] I've read the FAQ.
[X] I've read Instructions for logging issues.
[X] I'm not using cypress-cucumber-preprocessor@4.3.1 (package name has changed and it is no longer the most recent version, see #689).

badeball commented 2 years ago

You’re probably encountering funny / unexpected NPM behaviour, but it’s difficult to say because you’re leaving out like the only relevant piece of information, namely the source(s). You need to share your package.json.

richardszanyi-kasa commented 2 years ago

Thank you for that, Here it is:

"devDependencies": {
    "@bahmutov/cypress-extends": "^1.1.0",
    "@cypress/browserify-preprocessor": "^3.0.2",
    "@percy/cli": "^1.0.0-beta.52",
    "@percy/cypress": "^3.1.0",
    "@typescript-eslint/parser": "^5.33.0",
    "cypress-iframe": "^1.0.1",
    "cypress-plugin-stripe-elements": "^1.0.1",
    "cypress-slack-reporter": "^1.2.1",
    "cypress-social-logins": "^1.11.2",
    "cypress-terminal-report": "^4.1.2",
    "docolatte": "^2.10.2",
    "eslint": "^8.22.0",
    "mochawesome": "^7.1.3",
    "mochawesome-merge": "^4.2.1",
    "mochawesome-report-generator": "^6.2.0",
    "path": "^0.12.7",
    "resolve": "^1.22.1",
    "stream": "^0.0.2"
  },
  "dependencies": {
    "@badeball/cypress-cucumber-preprocessor": "^12.0.1",
    "@cucumber/cucumber": "^7.0.0",
    "@typescript-eslint/eslint-plugin": "^5.33.0",
    "aws-sdk": "^2.932.0",
    "axios": "^0.27.2",
    "clean-jsdoc-theme": "^3.3.1",
    "commander": "^7.2.0",
    "cypress": "^10.6.0",
    "cypress-commands": "^1.1.0",
    "cypress-real-events": "^1.7.1",
    "cypress-waitfor": "^1.1.0",
    "dayjs": "^1.10.4",
    "express": "^4.18.1",
    "jira-client-xray": "^1.0.1",
    "jsdoc-cypress-cucumber-plugin": "^1.1.0",
    "lodash": "^4.17.21",
    "luxon": "^1.26.0",
    "mocha": "^10.0.0",
    "mongodb": "^4.7.0",
    "namecase": "^1.1.2",
    "prettier": "^2.5.1",
    "prettier-eslint": "^13.0.0",
    "ts-loader": "^9.3.1"
  },
  "cypress-cucumber-preprocessor": {
    "nonGlobalStepDefinitions": true,
    "nonGlobalStepBaseDir": "./e2e/stepDefinitions/**",
    "stepDefinitions": "./e2e/stepDefinitions/**/*.ts",
    "cucumberJson": {
      "generate": true,
      "outputFolder": "cypress/cucumber-json",
      "filePrefix": "",
      "fileSuffix": ".cucumber"
    }
  }

badeball commented 2 years ago

Congrats on discovering the horrible and ever-changing reality of how NPM treats peer deps. Even though esbuid is an optional peer dep and you don't use it (you use browserify), you need to satisfy the contraint because otherwise some other package would do it wrongly. Run npm i esbuild@0.14.

badeball commented 2 years ago

I've pushed an updated version of @badeball/cypress-configuration that hopefully helps to reduce noice, although I wish it was unnecessary.

badeball / cypress-cucumber-preprocessor