Closed tennox closed 9 months ago
I realized a few other things were missing that I didn't want to implement myself (ID token deserialization, user storage, ..) so I ended up pivoting to oidc-client-ts :tipping_hand_man: (although it's less modern and so on :sweat_smile:
I thought about it - this branch works fine... so it could still be merged as a starting point :thinking:
But at your discretion, dear maintainers - and thx anyways :)
Hi @tennox ,
It's tricky. Some people requested adding a few more properties (like idToken), which I get, but the question then becomes: how much of OIDC do we implement?
If we do a little, feature requests will continue to roll in. If we do the whole thing, a major issue is that we would need a JWT implementation and this library becomes a lot larger.
So the only 2 ways forward I see are:
so yeah im not really sure what to do with this, but I do really appreciate the work. You could publish this code as your own package and make my library a dependency maybe?
Hey @evert ,
I see. I think this lib convinced me by being lean and small, so I think adding a lot doesn't help.
In general, as I said, I ended up using the other lib that is made for oidc, because there was more things it did for me - so I I'm not very invested into this decision about this lib 🤔
My take on it is that it could be really useful that, if you only need Auth without JWT/userinfo stuff (but having id_token), maybe having this lib supporting that (and only that, as a clear scope) would be a good thing - but it's a made-up example, so the realistic scenarios are rather small I think.
So I guess I'll close this and the lib stays with it's current focus.?
Maybe a hint in the readme about this? "This library focuses on OAuth2 only. If you need OIDC support, check out e.g. oidc-client-ts" or smth like that 🤔
In any case - thanks for your work & responsiveness ♥️
I'm working on adding first-class OIDC support:
Related to issues #67 & #68