search

badgateway / tt-app

Time tracker app using the Bad Gateway suite of opensource tools. Related: https://github.com/badgateway/tt-api
MIT License
1 stars 0 forks source link

Let the user know why their Entry was not submitted #50

Closed syedfkabir closed 1 year ago

syedfkabir commented 2 years ago

Task

This is a follow up to https://github.com/badgateway/tt-app/pull/49

You can now successfully submit an Entry, however if you do not have a Project selected, you'll get a console error.

After some discussion with the Bad Gateway team: The submit button should not be disabled The user should be able to hit submit and see why their submission was not successful This can be done using the required keyword on a <form>, however we are currently not using one Update the component to now use a form

Screenshot

Screen Shot 2022-10-20 at 12 53 54 PM
ikbensiep commented 2 years ago

If you're a Real Cool Guy, add a required attribute to the <select> and the browser will not submit until it contains a valid value (ie a user has selected an actual option)

syedfkabir commented 2 years ago

If you're a Real Cool Guy

how easy it is to manipulate me, ill check it out :p

BeckyPollard commented 2 years ago

Having some GitHub UI struggles, don't mind this open/close noise an attempt was made