search

badger707 / esb-smart-meter-reading-automation

Automated Smart Meter readings data collection from ESB Ireland registred account (regardless of your current supply provider)
https://myaccount.esbnetworks.ie
46 stars 11 forks source link

Pulling data #6

Closed vitopiepoli closed 2 months ago

vitopiepoli commented 2 months ago

The data is no more available using the code proposed. At line 65 it returns a HTML page, probably error page message. How do we get the new query schema or parameters to be passed?

Jesus-M commented 2 months ago

ESBN changed their website and now there are different options to download the data.

It would be great to be able to decide which file we want to download

image

vitopiepoli commented 2 months ago

My understanding is that the code goes directly to the source of the data. It would be great to know the new schema.

Jesus-M commented 2 months ago

Yes, but the source has changed now.

vitopiepoli commented 2 months ago

Agree, we need to know if that is even feasible now.

badger707 commented 2 months ago

I'm looking at this.

badger707 commented 2 months ago

I have it working now, need to tidy-up the code and will push the changes tomorrow.

vitopiepoli commented 2 months ago

That is great. I had to write a bit with selenium to download the csv file and import in my analytics. Would you mind to briefly explain what changed?

badger707 commented 2 months ago

Yes, look at comment from @Jesus-M

vitopiepoli commented 2 months ago

Sorry, I did not explain myself well.

I have seen that they changed the source but I was wondering what did you change in your code to get the data for the ESB database. Would you also be interested getting the piece of code I wrote to download the 30 minutes csv file?

badger707 commented 2 months ago

Closing, code updated to reflect new changes.

Jesus-M commented 2 months ago

The changes work fine, thanks for that, but maybe there is a 'print' missing at the end?

badger707 commented 2 months ago

@Jesus-M just add print on json_out.

Jesus-M commented 2 months ago

Yes, that's what I did to test the changes, although in my final use of it, I will go with CSV.

Thanks once again for the work!!