badgerloop-software / pod-dashboard

The Operator's Dashboard

http://badgerloop.com

GNU General Public License v3.0

6 stars 2 forks source link

Start and stop recording #108

Closed rednazer closed 5 years ago

rednazer commented 5 years ago

Description

Please include a summary of the change and which issue (if applicable) is fixed I added the feature to start and stop the recording of data and changed naming convention of exported json files to include seconds (this was to fix a bug where recording 2 times in the same minute would overwrite the first data record).
Resolves #103 (delete if n/a)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation (readme)
[X] My changes generate no new warnings or errors
[X] I have added tests/examples that prove my fix is effective or that my feature works
[X] New and existing lint guidelines/tests/examples pass with my changes (run npm test locally)

EUdds commented 5 years ago

Overall this looks really awesome!! Just adjust the event names and it'll be ready for master!!

rednazer commented 5 years ago

I fixed the naming convention, added a comment on createCache and removed the removed element in dynamicloading.js.

EUdds commented 5 years ago

Lol https://www.reddit.com/r/javascript/comments/66ij5p/what_is_an_eslint_rule_that_you_could_not_do/dgiwl5i?utm_source=share&utm_medium=web2x