ezraboley commented 4 years ago

Description

Please include a summary of the change and which issue (if applicable) is fixed I re-wrote the Timer class to be a lot simpler and have a cleaner interface. It also no-longer uses an internal time, it will instead generate the time on-demand. I clocked it against a timer on my phone for 2 minutes and found no noticeable difference in the duration listed.
Resolves #97

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (readme)
[x] My changes generate no new warnings or errors
[ ] I have added tests/examples that prove my fix is effective or that my feature works
[x] New and existing lint guidelines/tests/examples pass with my changes (run npm test locally)

EUdds commented 4 years ago

You can see in this chart that there is still an increasing saw tooth trend on our memory usage. So I'm going to say that this closes #97 but until we figure out what's causing that increasing memory usage, I want to leave #88 open

EUdds commented 4 years ago

With that being said, this is a lot better and I am not experiencing slowdowns either. I just want to make sure we're not pushing it further back.

ezraboley commented 4 years ago

You can see in this chart that there is still an increasing saw tooth trend on our memory usage. So I'm going to say that this closes #97 but until we figure out what's causing that increasing memory usage, I want to leave #88 open

I'm not entirely sure still why it's steadily increasing, but I think the sawtooth is normalish since you're just seeing garbage collection periodically (hence drop down in heap usage). Could be if the autosave is being updated through a read/update/write pattern?

EUdds commented 4 years ago

I ran a half hour long memory test and turns out that memory does stabilize and this seems to fix our memory issues . I will close that issue

badgerloop-software / pod-dashboard

Fixed the timer #123

Description

Type of change

Checklist