badgerloop-software / solar_car_hardware

Repository for solar car electrical hardware made in Altium Designer.
5 stars 1 forks source link

MainIO Schematic Review #22

Open dawiggleman opened 2 years ago

dawiggleman commented 2 years ago

Review of MainIO schematics

dawiggleman commented 2 years ago

1) Add title page with title and board revision number 2) Add sub-titles to each page, to tell which circuit you are displaying 3) Add reference designators to all parts (tools --> annotation --> annotate schematics quietly (for a flat hierarchy design))

image Is this where CAN swaps TX/RX? Regardless, maybe add a note denoting this is the correct orientation

image What's the voltage drop on this LED? If it's < 1.6V or so, probably want a larger resistor so your current is < 25mA

Make note on Crystal to route according to datasheet: image

dawiggleman commented 2 years ago

Add no ERC directives to unused pins in shutdown circuit: image

For entire shutdown circuit: label what each "node" is protecting (i.e. IMD, E-stop switch)

Explain/title what this circuit does: image

I'd check that the relay can be driven with current flowing this way (B field will be different). (It's opposite in all your other circuits): image

There's no power attached to Vin on this regulator: image

Why use a 10,000pf part when you've got lots of 0.1 uf parts elsewhere? (Bom reduction) image

Put note on expected holdup time/reason for all these caps: image

mmfarah commented 2 years ago

"Is this where CAN swaps TX/RX? Regardless, maybe add a note denoting this is the correct orientation"

"What's the voltage drop on this LED? If it's < 1.6V or so, probably want a larger resistor so your current is < 25mA"

"Why use a 10,000pf part when you've got lots of 0.1 uf parts elsewhere?"