search

badges / shields

Concise, consistent, and legible badges in SVG and raster format
https://shields.io
Creative Commons Zero v1.0 Universal
23.87k stars 5.51k forks source link

Refactor - use renderVersionBadge - part 4 [githubrelease githubtag] #10656

Closed jNullj closed 1 week ago

jNullj commented 2 weeks ago

This pull request refactors the codebase to use the renderVersionBadge function for rendering version badges. Refactored github releases and github tags. The pull request also modifies tests where needed.

I added forcePrerelease option to renderVersionBadge for github, might be usefull for any api that indicates prerelease explicitly.

while for github release we don't effect colors, for github tags this pr changes the logic a bit, and improves horizontal consistency. we used to mark all tags blue if user picked latest over semver sort. this is odd as with releases we do mark prerelease in orange. I guess the diffrence is due to api indicating prereleases, but we already try to guess prereleases in renderVersionBadge so i figured we might just as well try and use it while increasing consistency.

This PR should be the last in this refactor, we do have a few outliers services like `

visual-studio-app-center-releases-osversionorclojars` but i couldn't find anything else to refactor, let me know if you find anything. Until you do, closes #2026

github-actions[bot] commented 2 weeks ago
Warnings
:warning: This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
:book: :sparkles: Thanks for your contribution to Shields, @jNullj!

Generated by :no_entry_sign: dangerJS against dfc6d83b98e265b1022dae31e7f327f0c78d6205